On 29/08/2011 2:15 PM, jojelino wrote:
On 2011-08-30 AM 5:23, Christopher Faylor wrote:
Maybe Corinna will disagree but I think there is way too much code
change here for me to be comfortable with including it. It looks like
it would be an ongoing maintenance issue, requiring constant vigilance
to avoid code rot. And, it would have to be very carefully studied to
make sure there aren't more gotchas like 'if "" ""'.
Yes, I see. but there would be months for the missing comments, and i
have not enough time to test this patch for now.
and there were bugs in previous patch. so i attach the revised one.
I haven't been studying the code, but the phrases "lots of code", "no
comments" and "not tested" ring major alarm bells for me...
$0.02
Ryan
