On Feb 22 10:51, Corinna Vinschen wrote: > On Feb 22 03:40, Yaakov wrote: > > On Fri, 22 Feb 2013 09:49:51 +0100, Corinna Vinschen wrote: > > > > access should go, no doubt about it. > > > > > > > > For get_osfhandle and setmode I would prefer maintaining backward > > > > compatibility with existing applications. Both variations, with and > > > > without underscore are definitely in use. > > > > > > > > What about exporting the underscored variants only, but define the > > > > non-underscored ones: > > > > > > > > extern long _get_osfhandle(int); > > > > #define get_osfhandle(i) _get_osfhandle(i) > > > > > > > > extern int _setmode (int __fd, int __mode); > > > > #define setmode(f,m) _setmode((f),(m)) > > > > > > Just to be clear: On 32 bit we should keep the exported symbols, too. > > > On 64 bit we can drop the non-underscored ones (which just requires > > > to rebuild gawk for me) and only keep the defines for backward > > > compatibility. > > > > Like this? > > Almost. The _setmode needs a tweak, too. I also think it makes > sense to rename the functions inside of syscalls.cc: > [...]
I applied this patch to the 64 bit branch for now. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat