On 2017-12-20 16:10, Eric Blake wrote: > On 12/20/2017 05:01 PM, Brian Inglis wrote: >> --- >> winsup/doc/etc.postinstall.cygwin-doc.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/winsup/doc/etc.postinstall.cygwin-doc.sh >> b/winsup/doc/etc.postinstall.cygwin-doc.sh >> index 2873d9395..935bd94e1 100755 >> --- a/winsup/doc/etc.postinstall.cygwin-doc.sh >> +++ b/winsup/doc/etc.postinstall.cygwin-doc.sh >> @@ -52,7 +52,7 @@ fi >> # create User Guide and API PDF and HTML shortcuts >> while read target name desc >> do >> - [ -r $t ] && $mks $CYGWINFORALL -P -n "Cygwin/$name" -d "$desc" -- >> $target >> + [ -r $target ] && $mks $CYGWINFORALL -P -n "Cygwin/$name" -d "$desc" -- >> $target > > Wrong. Needs to be [ -r "$target" ] to be properly quoted.
>From working with Windows paths, I feel I often overdo the quotes: originally had both uses quoted, then seeing the diff, took them off again, pre-commit. Those are base Cygwin paths - don't *need* quotes - unless you feel shell var uses should be quoted just in case, or just in tests? -- Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada