On 10/17/19 4:55 PM, Ken Brown wrote: > On 10/16/2019 8:34 AM, Takashi Yano wrote: >> --- >> winsup/cygwin/fhandler_tty.cc | 26 +++++++++++++------------- >> 1 file changed, 13 insertions(+), 13 deletions(-) >> >> diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc >> index 1095c82eb..baf3c9794 100644 >> --- a/winsup/cygwin/fhandler_tty.cc >> +++ b/winsup/cygwin/fhandler_tty.cc
> > This and the previous patch look good to me, but we should probably wait > for Haubi to confirm that they fix the problems he reported. I'm unsure what the first patch does address: It does not fix the 'ssh -t' testcase, and I doubt it actually should. But it doesn't seem to break anything here so far. The second patch fixes the (minor) issue with the 'Last login' line as expected. /haubi/