On 30/11/2020 10:25, Corinna Vinschen wrote:
Hi Jon,
On Nov 24 13:37, Jon Turney wrote:
For ease of reviewing, this patch doesn't contain changes to generated
files which would be made by running ./autogen.sh.
v2:
* Include tzmap.h in BUILT_SOURCES
* Make per-file flags appear after user-supplied CXXFLAGS, so they can
override optimization level.
* Correct .o files used to define symbols exported by libm.a
* Drop gcrt0.o mistakenly incuded in libgmon.a
* Add missing line continuations in GMON_FILES value
v3:
* use per-file flags for .c compilation
* override C{XX,}FLAGS, as they are set on the command line by top-level make
Running autogen.sh shows a couple of warnings:
configure.ac:45: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or
'*_CPPFLAGS')
configure.ac:45: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or
'*_CPPFLAGS')
configure.ac:45: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or
'*_CPPFLAGS')
configure.ac:45: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or
'*_CPPFLAGS')
configure.ac:45: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or
'*_CPPFLAGS')
testsuite/cygrun/Makefile.am:16: warning: 'INCLUDES' is the old name for
'AM_CPPFLAGS' (or '*_CPPFLAGS')
configure.ac:45: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or
'*_CPPFLAGS')
automake: warning: redefinition of 'ps' ...
/usr/share/automake-1.16/am/program.am: ... 'ps$(EXEEXT)' previously defined
here
utils/Makefile.am:15: while processing program 'ps'
utils/mingw/Makefile.am:14: warning: 'INCLUDES' is the old name for
'AM_CPPFLAGS' (or '*_CPPFLAGS')
Something to worry about?
Thanks for taking a look.
These warnings are expected at the moment.
I plan to clean up INCLUDES -> CPPFLAGS in a future patch
The redefinition of 'ps' is due to a conflict between a target built
into automake for postscript documentation and an executable we have
called 'ps'. I'm not sure how to address that.
