On 18-01-2021 12:08, Corinna Vinschen via Cygwin-patches wrote: > On Jan 15 14:45, Ben Wijen wrote: >> Move post-dir unlink check from >> fhandler_disk_file::rmdir to _unlink_nt > > Why? It's not much of a problem, codewise, but the commit message > could be improved here. > Something like this? Cygwin: Move post-dir unlink check Move post-dir unlink check from fhandler_disk_file::rmdir to _unlink_nt This helps in two ways: * Now all checks are in one place * Even if a directory is removed through _unlink_nt, but not rmdir, the return value can be trusted.
- Re: [PATCH 02/11] syscall... Corinna Vinschen via Cygwin-patches
- Re: [PATCH 02/11] sys... Ben
- Re: [PATCH 02/11... Corinna Vinschen via Cygwin-patches
- Re: [PATCH 0... Ben
- [PATCH 04/11] syscalls.cc: Use EISDIR Ben Wijen
- Re: [PATCH 04/11] syscalls.cc: Us... Corinna Vinschen via Cygwin-patches
- [PATCH 03/11] syscalls.cc: Fix num_lin... Ben Wijen
- Re: [PATCH 03/11] syscalls.cc: Fi... Corinna Vinschen via Cygwin-patches
- [PATCH 05/11] Cygwin: Move post-dir un... Ben Wijen
- Re: [PATCH 05/11] Cygwin: Move po... Corinna Vinschen via Cygwin-patches
- Re: [PATCH 05/11] Cygwin: Mov... Ben
- Re: [PATCH 05/11] Cygwin:... Corinna Vinschen via Cygwin-patches
- [PATCH 06/11] cxx.cc: Fix dynamic init... Ben Wijen
- Re: [PATCH 06/11] cxx.cc: Fix dyn... Corinna Vinschen via Cygwin-patches
- [PATCH 07/11] syscalls.cc: Implement n... Ben Wijen
- [PATCH 08/11] path.cc: Allow to skip f... Ben Wijen
- Re: [PATCH 08/11] path.cc: Allow ... Corinna Vinschen via Cygwin-patches
- Re: [PATCH 08/11] path.cc: Al... Ben
- Re: [PATCH 08/11] path.cc... Corinna Vinschen via Cygwin-patches
- [PATCH 09/11] mount.cc: Implement poor... Ben Wijen