On 23.03.2021 11:10, Corinna Vinschen wrote:
[CC Marco, CC Jan]


Out of curiosity, I took a quick glance at the cmake code.  It appears that
this code is designed to support running cmake in a Console.  I don't think
that should be needed any more, if it ever was.
[...]
I think the following might suffice (untested):

--- a/Source/kwsys/Terminal.c
+++ b/Source/kwsys/Terminal.c
@@ -10,7 +10,7 @@
  #endif

  /* Configure support for this platform.  */
-#if defined(_WIN32) || defined(__CYGWIN__)
+#if defined(_WIN32)
  #  define KWSYS_TERMINAL_SUPPORT_CONSOLE
  #endif
  #if !defined(_WIN32)

noted.
cmake was always annoying, we remove this type of define and they add
somewhere else


Looks right to me.  If we patch cmake to do the right thing, do we still
need this patch, Takashi?


Thanks,
Corinna

Regards
Marco

Reply via email to