Hi Jon,
the patch is fine, but...
On Nov 12 14:30, Jon Turney wrote:
> On 04/11/2022 15:29, Pedro Alves wrote:
> > On 2022-11-04 12:53 p.m., Jon Turney wrote:
> > > +<para>
> > > + (It may be necessary to use the <command>gdb</command> command
> > > <command>set
> > > + disable-randomization on</command> to turn off ASLR for the debugee to
> > > + prevent the base address getting randomized.)
> > > +</para>
> > > </answer></qandaentry>
> >
> > Typo: debugee -> debuggee
>
> Thanks for catching that.
>
> Patch attached.
>
> > Note that "on" is the default.
>
> True. But the API used by gdb to turn off ASLR isn't supported by some
> versions of Windows.
>
> This sentence could be a lot more explicit about all the details here, but
> I'm just trying to be brief.
> From be24c9b69e72648690a477fd2f15b0a9c6374713 Mon Sep 17 00:00:00 2001
> From: Jon Turney <jon.tur...@dronecode.org.uk>
> Date: Sat, 12 Nov 2022 14:16:36 +0000
> Subject: [PATCH] Cygwin: Fix typo in FAQ
>
> The consonant in 'debug' is doubled in 'debuggee' just as it is in
> 'debugger'.
>
> Fixes: 8c68a8a4
It would be great if we could get used to using the same syntax as the
Linux kernel project to document stuff. I'm trying to follow their lead
for a while. For fixes to former commits, it looks like this in the
kernel, at the end of the commit message:
Fixes: 123456789012 ("title of commit 123456789012")
Yeah, core.abbrev is 12 digits. I'm using this setting for quite some
time locally.
Anyway, please push.
Thanks,
Corinna
