On Sat, 7 Jun 2025 18:23:40 +0900
Takashi Yano <[email protected]> wrote:
> On Sat, 31 May 2025 10:16:22 +0900
> Takashi Yano wrote:
> > Currently, _cygtls::sigmask is set in call_signal_handler(), but this
> > is too late to effectively prevent a masked signal from being armed.
> > With this patch, sigmask is set in _cygtls::interrupt_setup() instead.
> >
> > Fixes: 0d675c5d7f24 ("* exceptions.cc (interrupt_setup): Don't set signal
> > mask here or races occur with main thread. Set it in sigdelayed instead.")
> > Reviewed-by:
> > Signed-off-by: Takashi Yano <[email protected]>
> > ---
> > winsup/cygwin/exceptions.cc | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
[...]
>
> I'd withdraw this patch because this patch seems to cause a race
> issue as mensioned in the commit message of the commit 0d675c5d7f24.
>
> Instead, I would like to propose another patch for the sema purpose.
> https://cygwin.com/pipermail/cygwin-patches/2025q2/013749.html
So, I have currently three signal patches waiting for review.
https://cygwin.com/pipermail/cygwin-patches/2025q2/013731.html
https://cygwin.com/pipermail/cygwin-patches/2025q2/013733.html
https://cygwin.com/pipermail/cygwin-patches/2025q2/013749.html
--
Takashi Yano <[email protected]>
