Hi Pavel,
On May 5 22:28, Pavel Pavlov wrote:
> Hi,
>
> The patch is self explanatory. This fixes errors/waring from hostent::h_name:
>
> ```
> [6/14] Building C object CMakeFiles/http.dir/ext/c-ares/libcares.c.o
> In file included from /d/work-pps/ext/c-ares/libcares.c:26:
> /d/work-pps/ext/c-ares/src/lib/ares_free_hostent.c: In
> function ‘ares_free_hostent’:
> /d/work-pps/backtest-engine/ext/c-ares/src/lib/ares_free_hostent.c:41:17:
> warning: passing argument 1 of ‘ares_free’ discards ‘const’ qualifier
> from pointer target type [-Wdiscarded-qualifiers]
> 41 | ares_free(host->h_name);
> | ~~~~^~~~~~~~
> ```
>
> The patches to the Cygwin sources are under the 2-clause BSD license.
Thanks, but the patch is missing a fix for Cygwin itself:
winsup/cygwin/net.cc: In function ‘hostent* cygwin_gethostbyname(const char*)’:
winsup/cygwin/net.cc:841:24: error: invalid conversion from ‘const char*’ to
‘char*’ [-fpermissive]
841 | tmp.h_name = name;
| ^~~~
| |
| const char*
make[4]: *** [Makefile:2123: net.o] Error 1
Would you mind to add this to your patch and also, please add a
Signed-off-by:.
Thanks,
Corinna
