On Jun 20 13:24, Sebastian Feld wrote:
> On Tue, Jun 17, 2025 at 1:16 PM Corinna Vinschen
> <[email protected]> wrote:
> >
> > Hi Sebastian,
> >
> > On Jun 17 09:48, Sebastian Feld wrote:
> > > The following patch increases from 10 to 63, per Windows spec
> > > https://learn.microsoft.com/en-us/windows/win32/fileio/reparse-points
> > >
> > > Security impact is minor, SYMLOOP_MAX is just an artificial limiter to
> > > prevent endless loops.
> >
> > In case of Cygwin (Cygwin is slow, we all know that), the rather low
> > SYMLOOP_MAX was chosen so the path handling didn't get even slower in
> > some circumstances I don't remember anymore.  Maybe the times when this
> > was relevant are over, so we can try this.
> 
> 1. Cygwin is NOT slow. Who says that?

It's an old meme.

> 2. If there is a performance impact, then this should be documented in
> the source code.
> 
> > However, please send a real git patch created with `git format-patch'
> > and don't forget your Signed-off-by:".
> 
> Patch attached.

Pushed.

> Are there CI or regression test scripts where I could add a test module?

You can add something to winsup/testsuite I guess.


Thanks,
Corinna

Reply via email to