On Thu, 26 Jun 2025 14:22:49 +0900 Takashi Yano wrote: > On Wed, 25 Jun 2025 17:57:56 +0200 (CEST) > Johannes Schindelin wrote: > > Hi Takashi, > > > > On Wed, 25 Jun 2025, Takashi Yano wrote: > > > > > On Wed, 25 Jun 2025 20:51:02 +0900 > > > Takashi Yano wrote: > > > > On Wed, 25 Jun 2025 19:55:34 +0900 > > > > Takashi Yano wrote: > > > > > Hi Johannes, > > > > > > > > > > On Wed, 25 Jun 2025 09:38:17 +0200 (CEST) > > > > > Johannes Schindelin wrote: > > > > > > Hi Takashi, > > > > > > > > > > > > On Wed, 25 Jun 2025, Johannes Schindelin wrote: > > > > > > > > > > > > > On Wed, 25 Jun 2025, Takashi Yano wrote: > > > > > > > > > > > > > > > I'd revise the patch as follows. Could you please test if the > > > > > > > > following patch also solves the issue? > > > > > > > > > > > > > > Will do. > > > > > > > > > > > > For the record, in my tests, this fixed the hangs, too. > > > > > > > > > > Thanks for testing. > > > > > However, I noticed that this patch changes the behavior Corinna was > > > > > concerned about. > > > > > > > > The behaviour change can be checked using attached test case. > > > > > > Hmm, then, nga888(Andrew Ng @github)'s solution seems to be > > > the best one. > > > https://github.com/git-for-windows/git/issues/5688#issuecomment-2995952882 > > > > "Best" by what rationale? That it passes the attached test case (which is > > not a test case, by the way, as there are no assertions that can fail, and > > it is not integrated into the test case, please fix both aspects before > > you call it a test case). > > The "bug fix" should not change the current code intent. nga888's patch > keeps the code intent regarding write size for non-blocking write, while > other patches do not.
No! I was wrong. nga888's patch trys to write more than available space just like blocking write. Let me consider. -- Takashi Yano <takashi.y...@nifty.ne.jp>
