On Mon, 30 Jun 2025 12:18:27 +0200 (CEST)
Johannes Schindelin wrote:
> Hi Takashi,
> 
> On Fri, 27 Jun 2025, Takashi Yano wrote:
> 
> > There are tree variables for similar purpose in raw_write(), avail,
> > chunk, and len1. avail is the amount of writable space in the pipe.
> > len1 is the data length to attempt to NtWriteFile(). And chunk is
> > intermediate value to calculate len1 from avail which holds
> > min(avail, len). Here, chunk has no clear role among them. In fact,
> > it appears to obscure the intent of the code for the reader.
> > 
> > This patch removes the use of chunk and obtains len1 directly from
> > avail.
> 
> Now that this diff no longer conflicts with the SSH hang fix (because you
> dug deeper and identified a different part of the code as needing to be
> fixed), I'd be very happy if you fast-tracked this patch.

Thansk for reviewing all the pipe fix patches. I'll push them.

-- 
Takashi Yano <[email protected]>

Reply via email to