On 2025-10-06 11:50, Evgeny Karpov wrote:
A gentle reminder to review the patch.
https://cygwin.com/pipermail/cygwin-patches/2025q3/014306.html
As gawk is a Cygwin Base category package, it should be one of the first
packages installed on all Cygwin systems, so the test should not be necessary,
unless /usr/bin is not in the PATH: a message to that effect might be more
useful; for example:
if ! command -v gawk &> /dev/null; then
echo "${0##*/}: gawk: command not found in PATH=$PATH." >&2
exit 127 # command not found
fi
It might also be useful to:
- check for $CXXCOMPILE available;
- near the bottom, change `awk` to `gawk` for consistency as it has been
checked;
- if context is not aligned, return the original value if context % 16 -ne 0;
- and maybe leave the output file around as evidence of an issue;
for example:
MOD=$(gawk '/_cygtls.context_p/{ print $3 % 16 ? $3 : 0; }' "${output_file}")
if [ $MOD -ne 0 ]
then
echo "${0##*/}: $output_file: _cygtls.context: $MOD: not 16 byte aligned"
# /bin/rm -f "${output_file}" # should we remove the evidence?
exit 1
fi
--
Take care. Thanks, Brian Inglis Calgary, Alberta, Canada
La perfection est atteinte Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter not when there is no more to add
mais lorsqu'il n'y a plus rien à retrancher but when there is no more to cut
-- Antoine de Saint-Exupéry
