> Just one nit for now. The first patch contains newlib/Makefile.in but not > newlib/Makefile.am. > Please make sure to change Makefile.am instead.
Hi Corinna, Thank you for the review. The changes in Makefile.in is directly due to the Cygwin build workflow[1] (cygwin.yml), which does not run a configure step for the newlib subtree, unlike what is done for the winsup directory. As a result, the changes made in Makefile.inc (as in this case) would not propagate into the build. The functional changes themselves are confined to newlib/libm/Makefile.inc, which is included by newlib/Makefile.am, and therefore, would normally be reflected in the generated newlib/Makefile.in. However, since the newlib subtree is not reconfigured in workflow, the corresponding updates were applied directly to Makefile.in which were regenerated using automake in local setup. [1]- https://github.com/cygwin/cygwin/blob/9fac993ba74bd6ab3fc638a169ffdc92b78bd679/.github/workflows/cygwin.yml#L150 Thanks & regards Thirumalai Nagalingam <[email protected]> ⚠️ External Email Warning: This message originated from outside the organization (McW). Be cautious - Never share passwords or click unexpected links/attachments.
