On 11/10/2011 11:29 AM, Ryan Pavlik wrote:
On Wed, Nov 9, 2011 at 1:11 PM, Charles Wilson wrote:
You *think* you're safe in assuming that WIN32 == !__CYGWIN__,
but...#include<jpeg.h> breaks all your assumptions. But jpeg.h *did
nothing wrong*.
It's better to be explicit.
--
Chuck
OK, so this leads me to the next question: The existing codebase has
substantial numbers of places with #if defined(WIN32) - do these all
imply #if defined(WIN32)&& !defined(__CYGWIN__) ?
That I don't know.
I generally
avoided touching things I didn't have to,
A good policy.
but this may be worth
clarifying codebase-wide.
Perhaps -- I'll leave that call to others. I suspect a global patch that
affected only #if lines should be a separate patch from any other
changes, if taking this action was desirable.
--
Chuck
--
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Problem reports: http://cygwin.com/problems.html
Documentation: http://x.cygwin.com/docs/
FAQ: http://x.cygwin.com/docs/faq/
