Bruce Korb wrote:
Earnie Boyd wrote:

This patch passes my test.  What do we need to do to get this accepted
into libtool cvs HEAD?

+  newargz[0] = xstrdup("/bin/sh");

This may not be the shell and there is no point allocating it.
It is fine to use it from static memory.
Okay, the second comment (use static string, not allocated memory) is easy enough. But what's the best way to use "the shell"? Do a unquoted replacement (<<EOF, not <<"EOF") e.g.

...
newargz = XMALLOC(char *, argc+2);
EOF
$echo >> $cwrappersource <<EOF
newargz[0] = \"$SHELL\";
EOF
$echo >> $cwrappersource <<"EOF"
newargz[1] = fnqualify(argv[0]);
...

?

--Chuck



--
Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
Bug reporting: http://cygwin.com/bugs.html
Documentation: http://cygwin.com/docs.html
FAQ: http://cygwin.com/faq/

Reply via email to