On Fri, Mar 18, 2022 at 2:15 PM Takashi Yano <takashi.y...@nifty.ne.jp> wrote: > > On Fri, 18 Mar 2022 13:21:00 +0200 > Orgad Shaneh wrote: > > > Git for Windows > > > > Were you able to reproduce? > > > > I found an easier way to reproduce, which works almost every time. > > > > It still happens only on Git Bash, and not on MSYS2 MINGW64, although > > I use the same dll in both. I have no idea why there's a difference. > > :/ > > > > I run Windows Terminal, but it reproduces also in cmd, as you tried. > > > > 1. In Control Panel -> Keyboard, set Repeat delay to shortest and > > Repeat rate to fastest. > > 2. In msys2-runtime run git fetch > > 3. Type git and press and hold q > > Thanks. I can reproduce the issue. I think I found the cause. > The two unexpected things happen. > > (1) wVirtualKeyCode and wVirtualScanCode of readback key event may > be null'ed even if they are not zero on WriteConsoleInputW(). > Therefore, memcmp() report the event is not equal. > (2) WriteConsoleInputW() may not be atomic. The event sequence which > is written by WriteConsoleInputW() may be inserted by key input > in the middle of the sequence. > > A patch for these issues is attached. Could you please test? > > -- > Takashi Yano <takashi.y...@nifty.ne.jp>
Awesome, looks good now. Thank you very much! Hope this is the last bit :) - Orgad -- Problem reports: https://cygwin.com/problems.html FAQ: https://cygwin.com/faq/ Documentation: https://cygwin.com/docs.html Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple