Hi Takashi,

On 6/1/2024 10:18 AM, Takashi Yano via Cygwin wrote:
int
pthread::once (pthread_once_t *once_control, void (*init_routine) (void))
{
   /* Sign bit of once_control->state is used as done flag.
      Similary, the next significant bit is used as destroyed flag. */

        Typo: Similarly

   const int done = INT_MIN;            /* 0b1000000000000000 */
   const int destroyed = INT_MIN >> 1;    /* 0b1100000000000000 */

Shouldn't the constants in the comments have 32 bits? Other than that, LGTM. (But you should wait for Bruno to confirm before you commit.)

Ken

--
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

Reply via email to