On Wed, Apr 09, 2008 at 01:57:01PM -0400, Ken Murchison wrote: > Bron Gondwana wrote: >> On Tue, Apr 08, 2008 at 10:20:57AM -0400, Ken Murchison wrote: >>> I just put together a release candidate for Cyrus 2.3.12. I'd >>> appreciate any independent testing before I release this to the masses. >>> >>> http://www.contrib.andrew.cmu.edu/~murch/cyrus-imapd-2.3.12rc1.tar.gz >> Notably missing: >> http://cyrus.brong.fastmail.fm/patches/cyrus-skiplist-transactions-2.3.10.diff >> This is the code that makes it impossible to accidentally start a new >> transaction while still in a transaction on the same file. >> I've re-rolled it to apply directly on top of 2.3.12rc1 so it should >> apply cleanly to CVS as well... > > I got a signed/unsigned warning during compilation. I changed > tid->logstart and tid->logend to unsigned. It doesn't look like this will > break anything, but can you double check for me?
It looks fine to me (just reading it). I'll update my patch to change them. The certainly _are_ unsigned values, there's no sense in a negative offset in an mmap! Bron.
