Yes, 1.1.0 is probably sufficient, unless this bug is an issue with
Cyrus: https://github.com/tatsuhiro-t/wslay/pull/47
On 6/3/20 1:19 AM, ellie timoney wrote:
Cool, thanks for confirming that. So far it's sounding like 1.1.0 is probably
adequate, but I'll wait a little bit to see if Ken has any input once he's been
online
On Wed, Jun 3, 2020, at 2:58 PM, Anatoli wrote:
Hi Ellie,
When you configure it with your patch applied and 1.1.0 installed,
does Cyrus build okay?
Yes, it builds without errors.
Configure prints:
checking for WSLAY... yes
wslay: yes
And -lwslay is passed as arg numerous times during build process.
And effectively httpd binary includes references to wslay_event_xxx in
its symbols table.
Regards,
Anatoli
On 3/6/20 01:35, ellie timoney wrote:
In our "cyruslibs" package, the wslay submodule is at this commit:
commit 4a937cd (HEAD, origin/master, origin/HEAD, master)
Author: Tatsuhiro Tsujikawa <tatsuhir...@gmail.com>
AuthorDate: Fri Jun 8 23:19:03 2018 +0900
Commit: Tatsuhiro Tsujikawa <tatsuhir...@gmail.com>
CommitDate: Fri Jun 8 23:19:03 2018 +0900
Bump up version number to 1.1.1-DEV
Which is the commit immediately following the release-1.1.0 tag. So,
presumably, we're not dependent on any feature/fix that's only in the
unreleased version, because otherwise we would've bumped the cyruslibs
submodule to include those commits?
So, "1.1.1" might be a typo, or an anticipatory thing that didn't go anywhere
yet, I'm not sure.
When you configure it with your patch applied and 1.1.0 installed, does Cyrus
build okay?
Cheers,
ellie
On Wed, Jun 3, 2020, at 2:13 PM, Anatoli wrote:
Cyrus developers,
The configure script checks for wslay lib version 1.1.1, but the latest
version released is 1.1.0. So when it is installed, it reports:
checking for WSLAY... no
configure: httpd will not have support for WebSockets. Consider
installing libwslay
The wslay's github repo has a mention of a 1.1.1-DEV version. Not sure
if cyrus-imapd httpd requires something from it or if it was just a
typo and 1.1.0 is ok.
For the later case below is a patch.
Regards,
Anatoli
diff --git a/configure.ac b/configure.ac
index dc0e0fff2..30e925c60 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1631,7 +1631,7 @@ dnl AC_MSG_WARN([Your version of
OpenDKIM can not support iSchedu
AC_ARG_WITH(wslay, [AS_HELP_STRING([--without-wslay], [disable
WebSockets support (check)])],,[with_wslay="check"])
if test "x$with_wslay" = "xyes" -o "x$with_wslay" = "xcheck";
then
- PKG_CHECK_MODULES([WSLAY], [libwslay >= 1.1.1], [
+ PKG_CHECK_MODULES([WSLAY], [libwslay >= 1.1.0], [
AC_DEFINE(HAVE_WSLAY,[],
[Build WebSockets support into httpd?])
with_wslay=yes
--
Kenneth Murchison
Senior Software Developer
Fastmail US LLC
