I noticed that filenames (now source descriptors in my branch) are used for dict lookups etc. -- rather than relying on object identity to hold I implemented this for source descriptors too.
Currently I'll go ahead and emulate the old behaviour, i.e. just do string comparison on filenames (for FileSourceDescriptor). I'm kind of questioning this though -- one can refer to the same file in many ways (paths are not relative, however they can contain ".." and "."; and then comes symlinks etc.). Is this something that could cause bugs, or should I just let it fly by? One possibility that comes to mind is refactoring all the absolute/relative path business into FileSourceDescriptor; i.e. FileSourceDescriptor can be passed relative filenames etc. and asked for both relative and non-relative filenames. This would eliminate the need for first making the path absolute and then strip it off again afterwards in relative_position (a scheme which would break if I canonicalized the filenames (i.e. process ".." and ".") for proper comparison). -- Dag Sverre _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
