Robert wrote: > On Oct 16, 2008, at 9:47 AM, Dag Sverre Seljebotn wrote: >> I am very against doing anything with the testcases - the fact that >> they trigger gcc warnings is a *good* thing. > > I would rather have a trac tickets about this, and have much better > signal-to-noise ratio while running the doctest. If a change > introduces warnings (especially real one) then I'd rather be able to > see them loud and clear--right now I probably wouldn't notice. > >> (Disclaimer: I didn't actually read the patch as I am on my cell, >> answering to the contents of your post.) > > The patch turns unused local vars into used local vars.
And Lisandro just reported a rather nasty bug where Cython would silently produce uncompileable code (not warnings, plain errors) for unused variables. (Global, but still.) The "entry.used" stuff is non-trivial, and removing the testcases which exercise that is not a good thing. OK, time to find some common ground here: - The patch is not bad in itself, but I strongly feel it should be accompanied by a new testcase unused_symbols.pyx, where all necesarry, non-duplicate tests are moved. - Then this can be moved to tests/broken and a ticket opened for it, referring to it. BTW, Lisandro, thanks for doing this and your attention to detail! My previous rant was a bit too harsh, and I'm slowly coming over to your side now. Dag Sverre _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
