On Fri, Oct 17, 2008 at 5:52 PM, Dag Sverre Seljebotn <[EMAIL PROTECTED]> wrote: > Lisandro wrote: >> Dag, review this, perhaps I'm missing something. > > Positive review (assuming the test_numpy.pyx testcase still runs of > course; I assume it will, but it is strange that it currently works > without a problem, as these are used in __getbuffer__ ...).
Well, it wotked because __getbuffer__ has an explicit cast. > BTW obviously all the available functions/macros should be defined in that > pxd, I just didn't get around to it. Any patches improving numpy.pxd in > this area will be accepted without any discussion (as long as the pointer > types are got right). > >> BTW, Did you notice that the 'return' type of the macro >> "PyArray_ITEMSIZE" is not 'Py_ssize_t' but 'int' (at least in >> numpy-1.2.0)??. Should this be fixed? > > Please do. It looks nicer (though it doesn't really matter for non-pointer > types, as it is C which is going to do the real typechecking in this case; > Cython only needs to know int vs. float and signed vs. unsigned). > OK, I'll take a look at what can be added/fixed/improved. -- Lisandro Dalcín --------------- Centro Internacional de Métodos Computacionales en Ingeniería (CIMEC) Instituto de Desarrollo Tecnológico para la Industria Química (INTEC) Consejo Nacional de Investigaciones Científicas y Técnicas (CONICET) PTLC - Güemes 3450, (3000) Santa Fe, Argentina Tel/Fax: +54-(0)342-451.1594 _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
