Hi Lisandro, thanks for fixing this.
Lisandro Dalcin wrote: > Stefan, please review this patch. This fixes the recently added > tests/run/dictintindex.pyx testcase. Could you add some more test cases to make sure this also works with negative values and unsigned types? From looking at the code, I'm not sure if these cases are handled as expected. > I had to add a new utility code, but I could not figure out how to > emit that utility code for the particular case of 'del obj[i]', I > mean, I do not know how to differentiate a setitem from a delitem. > Apart from that, the patch seems to work and all the testsuite pass. As Dag already wrote, utility code is generated at need (i.e. when they are used) during code generation. This avoids duplicating the necessary decision logic in the analysis and output phase. Stefan _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
