On Wed, Mar 11, 2009 at 12:43 PM, Dag Sverre Seljebotn <[email protected]> wrote: > Lisandro Dalcin wrote: >> Likely Dag should review this... If you agree on the patch, please >> push ... IMHO, this fix should go to 0.11 >> > I don't think I have anything to do with that code (though there's > likely other instances of the same problem in my Buffer.py). >
OK, sorry... For some reason I though that this was related to numpy support... > a) Saying that this should go into 0.11 means saying that this specific > bug is more important than everything else that sits in milestone 0.11.1 > in Trac. We probably put out 0.10 with the same bug and the Cython > project survived! We need to have some disipline and get things released > -- release early, release often. > I understand that... I just wanted to point that this fix likely does not have high impact and fix 64 bits issues, more or less like recent Robert's pushes did. > b) I don't know if I'm the right person to review, I don't know too much > about the Python API or size_t in this respect; it looks OK to me. Sorry again... > (If I > made the API in the first place I'd make the macro contain the entire > string, i.e. "d" and "ld", and not simply the "l" or nothing. My patch just mimics what CPython >= 2.5 does... > Some C versions have a "z" for size_t IIRC?) > In Py<2.5, Py_ssize_t is bare 'int' and the 'z' specifier is not handled in PyErr_Format(). -- Lisandro Dalcín --------------- Centro Internacional de Métodos Computacionales en Ingeniería (CIMEC) Instituto de Desarrollo Tecnológico para la Industria Química (INTEC) Consejo Nacional de Investigaciones Científicas y Técnicas (CONICET) PTLC - Güemes 3450, (3000) Santa Fe, Argentina Tel/Fax: +54-(0)342-451.1594 _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
