On Mar 9, 2009, at 2:05 PM, Stefan Behnel wrote: > Lisandro Dalcin wrote: >> Sending again, former message bounced because of 40k limit. >> >> The patch is almost ready, just waiting for review. The only thing I >> did not take is to remove the usage of PyNumber_Int(). Anyway, Cython >> already uses it, so the "brokeness" of my patch is similar to the >> current one :-) .. As I've introduced a __Pyx_PyNumber_Int() >> function, >> that is the only place that we should change to implement things >> as we >> want. > > I skipped through your patch a little. It's a fairly involved > change that > requires some testing, especially on different architectures and > platforms. > It might well be that the user experience is positive in that it > helps in > finding bugs and making user code more portable. My current gut > feeling is > that code that depends on the old behaviour here is broken anyway > and just > wasn't fixed yet because no-one noticed. > > But in any case, I would like to avoid breaking code for a micro > (bug-fix!) > release, unless there is at least some evidence that users > appreciate it. > > So, if anyone has code that does a bit of integer conversion > between Python > and C space, especially when working on a non-Intel or 64 bit > platform, > please give this patch a try.
Sage does this :). It's too late for 0.11 though. Is there a ticket up? - Robert _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
