On Mar 11, 2009, at 11:39 PM, Stefan Behnel wrote: > Hi all, > > I would like to encourage the following bug fixing procedure for > the future > 0.11.x releases. > > 1) Every patch that goes into a bug-fix release of Cython must be > backed by > a trac ticket. To get a trac account, please send a htpasswd entry to > Robert Bradshaw. > > 2) Every trac ticket must have a bug test case associated with it. > This > means that there must be a failing test case in tests/bugs/ named > "nicely_descriptive_name_here_Txyz.pyx" (where 'xyz' is the ticket > number), > or a patch in trac that adds this test case. See > > http://wiki.cython.org/HackerGuide > > Please try to do this even for the tricky cases that feel like > there isn't > a good test case. Reproducing a bug is critical for fixing it, and > having a > test case is critical for not breaking it in the future. > > 3) A working patch attached to the ticket will definitely > accelerate the > mainline bug fixing, although if you are unsure where to get > started, it's > usually better to ask on the mailing list before getting lost. > > 4) The Cython developers will assign priorities and milestones to trac > tickets. Tickets with working patches should be handled with > priority and > should at least receive a timely review. > > 5) When a bug is fixed, the test case must be copied from tests/ > bugs/ to > tests/run/ and the test suite must pass.
+1. In fact, I think even non-bugfixes should all be assigned a ticket on trac. (Some features may, of course, span many patches.) The only thing I would say is that I'd rather not clutter tests/run/-- perhaps we could put them somewhere else (or alternatively have runtests test all but a static list of known open tickets). - Robert _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
