On Nov 11, 2009, at 1:20 PM, Lisandro Dalcin wrote: > On Wed, Nov 11, 2009 at 6:50 PM, Robert Bradshaw > <[email protected]> wrote: >> On Nov 11, 2009, at 7:16 AM, Lisandro Dalcin wrote: >> >>> I marked this as a 0.12 blocker. Perhaps it is too much (though a >>> working patch is already provided), but figuring out the problem >>> took >>> a fair amount of time while helping Chris Colbert to debug the >>> issue. >>> >>> Please review: >>> >>> http://trac.cython.org/cython_trac/ticket/455 >> >> Thanks for tracking this down. It fixed the issue named, but broke >> cascaded comparison (i.e. you couldn't just "assert not >> coerce_result"). > > Interesting... I ran the whole testsuite and I did not noticed any > failure... perhaps I just got confused and did not see the problem... > Anyway, I put assert there just to try to spot problems, I knew my > patch was broken ;-)
That's because the test suite is still woefully incomplete... I added some relevant tests in that last patch. >> I pushed what you have and a followup to fix cascaded >> comparison too (couldn't think of a clean way to do this without >> introducing two on-line utility functions). >> > > Yes... it is a bit ugly, but no point in wasting more time to make it > look better :-) > > So, many thanks!!. Should I close the ticket? Or shall you do that? Yes, you can go ahead and close the ticket. - Robert _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
