Stefan Behnel wrote: > Christoph Gohlke, 05.02.2010 16:54: > >> Dear Cython developers, >> >> This is related to <http://trac.cython.org/cython_trac/ticket/50>. >> >> Cython 0.12.1 still generates string literals that can be too long for MSVC* >> compilers. Please consider the following patch. >> >> diff -r 8bff3332e34f Cython/Compiler/Code.py >> --- a/Cython/Compiler/Code.py Tue Feb 02 02:10:32 2010 -0800 >> +++ b/Cython/Compiler/Code.py Thu Feb 04 19:32:40 2010 -0800 >> @@ -667,7 +667,7 @@ >> decls_writer = self.parts['decls'] >> for _, cname, c in c_consts: >> decls_writer.putln('static char %s[] = "%s";' % ( >> - cname, c.escaped_value)) >> + cname, StringEncoding.split_docstring(c.escaped_value))) >> if c.py_strings is not None: >> for py_string in c.py_strings.itervalues(): >> py_strings.append((c.cname, len(py_string.cname), >> py_string)) >> > > I'm surprised that this works. The last information I had from an MSVC user > (and from a web search) was that just splitting the string into separate > auto-concatenated literals wouldn't solve the issue. > > Happy to read that it does. > Cristoph: Which version of MSVC are you using/did you/are you able to test this on?
IIRC, Stefan wrote some code in Cython for concatenating strings at run-time because of this issue. If that is indeed not necesarry, then it should probably be removed/cleaned up. Dag Sverre _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
