On Apr 24, 2010, at 11:00 AM, Stefan Behnel wrote:

> Hi,
>
> I managed to track down the ref-counting bug in the cython-closures  
> branch.
> Function arguments that participated in the closure were not always
> INCREFed, which induced several problems with the cleanup of the  
> closure
> class instance as it expected that any non-NULL field could safely be
> DECREF-ed. Especially errors during argument conversion were pretty  
> deadly.
>
> After this fix, all tests in the cython-closures pass, and even the
> failures in the Python regression suite start to get interesting.

Awesome!

> So, unless there are still objections from others, my vote is for  
> getting
> it merged back into mainline (it's already up-to-date with cython- 
> devel)
> and pushing out a 0.13 alpha. (Last I heard, Sage was still failing to
> build, but that doesn't have to keep us from getting an alpha  
> version out,
> does it?)


I think an alpha should be coming any day now, but the closures should  
be able to go in before release.

- Robert

_______________________________________________
Cython-dev mailing list
[email protected]
http://codespeak.net/mailman/listinfo/cython-dev

Reply via email to