Hi Haoyu, your GSoC branch has been around for a while now. Given that 0.13 will be out soon (soon-isher than ever before), is there anything that you consider safe enough to get merged into mainline after the release?
IMHO, any feature patch is a candidate, especially when it depends on currently illegal syntax (i.e. not impacting existing code). Everything that changes current behaviour is worth considering if it fixes a bug or Python compatibility issue but may have to wait for 0.14 if it impacts code that currently works with 0.13. BTW, it looks like only two trac tickets are currently assigned to you. I know you've been working on a lot more tickets, so it would be good to have your name on all of those that you provided a patch for. http://trac.cython.org/cython_trac/query?owner=haoyu From a quick look, I think #488 (ellipsis) is safe, but I'd like to see some more syntax tests - I bet there are some in Python's own test suite. Ticket #487 (multiple 'with' statements) looks nice, but clearly lacks test. I can't even see a test that makes sure the context managers are executed in the correct nesting order, neither can I see anything that tests the chaining of cleanup actions during exception propagation, let alone partial propagation in cases where one of the context managers swallows an exception. Again, Python's test suite will provide hints on better tests here. Ticket #490 (nonlocal), while I'd be happy to get it in, seems too big a change to go into 0.13.1. It seems you also have a fix for #477. That would be another candidate for 0.13.1. Note that the related test case doesn't actually test that the argument typing has the expected effect. This could be done using a tree assertion based on coercion nodes. Stefan _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
