2010/12/6 Stefan Behnel <[email protected]>:
> Vitja Makarov, 05.12.2010 08:41:
>>
>> I've updated patch.
>>
>> I removed pretty_name, bad idea should use name instead in
>> pydeclare_lambda.
>> `is_lambda` is now called `is_anonymous`, that means that entry itself
>> doesn't know how it will be named inside scope, so its anonymous (both
>> lambda and pyfunctions)
>
> That's ok and the patch looks good to me now.
>
> However, it lacks error tests and the modified code actually fails to detect
> redefinitions of cdef functions as Python functions and vice versa, which is
> not supported (and IMHO doesn't make sense either). Similarly, redefinitions
> in cdef classes aren't currently supported but are not detected either.
>
> I've attached a patch that currently breaks cpdef functions, but that
> handles (and tests) at least some of the error cases. I'm not sure what to
> do to fix the cpdef functions, though.
>
> BTW, note that there's a typo in the test name.
>
> Stefan
>
> _______________________________________________
> Cython-dev mailing list
> [email protected]
> http://codespeak.net/mailman/listinfo/cython-dev
>
>

I can't say it breaks cpdefs, this is "classic" cython behavior.
May by we need some flag like is_hardcoded?

-- 
vitja.
_______________________________________________
Cython-dev mailing list
[email protected]
http://codespeak.net/mailman/listinfo/cython-dev

Reply via email to