Author: clopes
Date: 2011-10-14 11:05:41 -0700 (Fri, 14 Oct 2011)
New Revision: 27182

Modified:
   cytoscapeweb/branches/compound/html-template/fixtures/test3.graphml
   cytoscapeweb/branches/compound/html-template/js/cytoscapeweb.js
   cytoscapeweb/branches/compound/html-template/js/tests.js
   cytoscapeweb/branches/compound/html-template/tests.html
Log:
Fixed QUnit tests

Modified: cytoscapeweb/branches/compound/html-template/fixtures/test3.graphml
===================================================================
--- cytoscapeweb/branches/compound/html-template/fixtures/test3.graphml 
2011-10-14 16:18:47 UTC (rev 27181)
+++ cytoscapeweb/branches/compound/html-template/fixtures/test3.graphml 
2011-10-14 18:05:41 UTC (rev 27182)
@@ -19,7 +19,7 @@
       <data key="label">n3</data>
       <data key="name">Node 3</data>
       <data key="shape">OCTAGON</data>
-      <data key="weight">0.09</data>
+      <data key="weight">0.6</data>
       <data key="ranking">3</data>
       <data key="type">1</data>
     </node>
@@ -28,7 +28,7 @@
       <data key="label">n1</data>
       <data key="name">Node 1</data>
       <data key="shape">RECTANGLE</data>
-      <data key="weight">0.45</data>
+      <data key="weight">0.3</data>
       <data key="ranking">1</data>
       <data key="type">1</data>
       <graph edgedefault="undirected">
@@ -37,7 +37,7 @@
           <data key="label">n4</data>
           <data key="name">Node 4</data>
           <data key="shape">ELLIPSE</data>
-          <data key="weight">0.25</data>
+          <data key="weight">0.34</data>
           <data key="ranking">4</data>
           <data key="type">1</data>
         </node>
@@ -46,7 +46,7 @@
           <data key="label">n2</data>
           <data key="name">Node 2</data>
           <data key="shape">RECTANGLE</data>
-          <data key="weight">0.6</data>
+          <data key="weight">0.2</data>
           <data key="ranking">2</data>
           <data key="type">1</data>
           <graph edgedefault="undirected">
@@ -55,7 +55,7 @@
               <data key="label">n5</data>
               <data key="name">Node 5</data>
               <data key="shape">ELLIPSE</data>
-              <data key="weight">0.35</data>
+              <data key="weight">0.01</data>
               <data key="ranking">5</data>
               <data key="type">1</data>
             </node>

Modified: cytoscapeweb/branches/compound/html-template/js/cytoscapeweb.js
===================================================================
--- cytoscapeweb/branches/compound/html-template/js/cytoscapeweb.js     
2011-10-14 16:18:47 UTC (rev 27181)
+++ cytoscapeweb/branches/compound/html-template/js/cytoscapeweb.js     
2011-10-14 18:05:41 UTC (rev 27182)
@@ -1270,7 +1270,7 @@
                if (list.length > 0) {
                        for (var i = 0; i < list.length; i++) {
                            var obj = list[i];
-                               if (filter(obj)) { arr.push(obj); }
+                               if (filter(obj)) { arr.push(obj.data.id); }
                        }
                 }
             } else if (this._typeof(filter) === "array") {

Modified: cytoscapeweb/branches/compound/html-template/js/tests.js
===================================================================
--- cytoscapeweb/branches/compound/html-template/js/tests.js    2011-10-14 
16:18:47 UTC (rev 27181)
+++ cytoscapeweb/branches/compound/html-template/js/tests.js    2011-10-14 
18:05:41 UTC (rev 27182)
@@ -35,7 +35,7 @@
        nodes: {
                shape: "RECTANGLE",
                opacity: 0.75,
-               size: { defaultValue: 12, continuousMapper: { attrName: 
"weight", minValue: 12, maxValue: 36 } },
+               size: { defaultValue: 12, continuousMapper: { attrName: 
"weight", minValue: 12, maxValue: 48 } },
                borderColor: "#333333",
                borderWidth: 4,
                selectionBorderColor: "#ff0000",
@@ -281,7 +281,6 @@
     });
     
     asyncTest("Select Nodes by ID", function() {
-       expect(6);
        var nodes = vis.nodes();
        var sel = [nodes[0].data.id, nodes[1].data.id];
        
@@ -794,7 +793,9 @@
                        ok(n.data.weight > 0.03 && n.data.weight < 0.4, "Node 
'"+n.data.id+"' correctly filtered ("+j+")");
                        ok(n.visible, "Filtered node '"+n.data.id+"' is visible 
("+j+")");
                        // When updateVisualMappers == false:
-                       same(n.size, nlookup[n.data.id].size, "The node size 
should not change ("+n.data.id+")");
+                       if (n.nodesCount == 0) { // ignore compound nodes
+                               same(n.size, nlookup[n.data.id].size, "The node 
size should not change ("+n.data.id+")");
+                       }
                });
        });
        $.each(nodes, function(i, n) {
@@ -859,37 +860,41 @@
        same(fAllList, null, "Return of listener for 'none' after removing 
filter by 'none'");
     });
     
-    asyncTest("Filter nodes and update mappers automatically", function() {
-       expect(2);
-       
-       vis.addListener("filter", "nodes", function(evt) {
-               start();
-               vis.removeListener("filter", "nodes");
-
-               var maxVal = -1, minVal = 999999;
-               var larger, smaller;
-
-               $.each(evt.target, function(i, n) {
-                       var size = n.size - n.borderWidth;
-                       if (size > maxVal) {
-                               larger = n;
-                               maxVal = size;
-                       } else if (size < minVal) {
-                               smaller = n;
-                               minVal = size;
-                       }
-               });
-
-               same(minVal, style.nodes.size.continuousMapper.minValue, "The 
node "+smaller.data.id+" should be smaller now");
-               same(maxVal, style.nodes.size.continuousMapper.maxValue, "The 
node "+larger.data.id+" should be bigger now");
+    var isCompoundGraph = vis.parentNodes().length > 0;
+    
+    if (!isCompoundGraph) { // continuous mapper for node size is hard to test 
because parent nodes' auto size! 
+           asyncTest("Filter nodes and update mappers automatically", 
function() {
+               expect(2);
                
-               vis.removeFilter("nodes");
-               stop();
-        });
-        
-        // Filter nodes and ask to update mappers:
-        vis.filter("nodes", nfilter, true);
-    });
+               vis.addListener("filter", "nodes", function(evt) {
+                       start();
+                       vis.removeListener("filter", "nodes");
+       
+                       var maxVal = -1, minVal = 999999;
+                       var larger, smaller;
+       
+                       $.each(evt.target, function(i, n) {
+                               var size = n.size - n.borderWidth;
+                               if (size > maxVal) {
+                                       larger = n;
+                                       maxVal = size;
+                               } else if (size < minVal) {
+                                       smaller = n;
+                                       minVal = size;
+                               }
+                       });
+                       
+                       same(minVal, 
style.nodes.size.continuousMapper.minValue, "The node "+smaller.data.id+" 
should be smaller now");
+                       same(maxVal, 
style.nodes.size.continuousMapper.maxValue, "The node "+larger.data.id+" should 
be bigger now");
+                       
+                       vis.removeFilter("nodes", true);
+                       stop();
+               });
+               
+               // Filter nodes and ask to update mappers:
+               vis.filter("nodes", nfilter, true);
+           });
+    }
     
     test("Add Node", function() {
        var nodes = vis.nodes();
@@ -1345,14 +1350,14 @@
        var xml = $(vis.xgmml());
        var nodes = vis.nodes();
        var edges = vis.edges();
-       var parents = vis.parentNodes();console.log(xml)
+       var parents = vis.parentNodes();
        
        same(xml[0].tagName.toLowerCase(), "graph", "<graph> tag");
-       same(xml.find("att graph").length, parents.length, "nested <graph> 
tags"); // compound graphs only
+       same(xml.find("att > graph").length, parents.length, "nested <graph> 
tags"); // compound graphs only
        same(xml.find("node").length, nodes.length, "Number of nodes");
-       same(xml.find("node graphics").length, nodes.length, "Number of node 
graphics");
+       same(xml.find("node > graphics").length, nodes.length, "Number of node 
graphics");
        same(xml.find("edge").length, edges.length, "Number of edges");
-       same(xml.find("edge graphics").length, edges.length, "Number of edge 
graphics");
+       same(xml.find("edge > graphics").length, edges.length, "Number of edge 
graphics");
     });
     
     test("SIF", function() {

Modified: cytoscapeweb/branches/compound/html-template/tests.html
===================================================================
--- cytoscapeweb/branches/compound/html-template/tests.html     2011-10-14 
16:18:47 UTC (rev 27181)
+++ cytoscapeweb/branches/compound/html-template/tests.html     2011-10-14 
18:05:41 UTC (rev 27182)
@@ -105,7 +105,7 @@
             };
         var vis3 = new org.cytoscapeweb.Visualization("cytoweb3");
         vis3.ready(function() { runGraphTests("Vis-3", vis3, options3); });
-
+        
         $.ajax({
             url: "fixtures/test3.graphml",
             dataType: "text",

-- 
You received this message because you are subscribed to the Google Groups 
"cytoscape-cvs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/cytoscape-cvs?hl=en.

Reply via email to