Branch: refs/heads/3.14.x
  Home:   https://github.com/cytoscape/cytoscape.js
  Commit: 75083ae462b808f52d15942a5e5240edf5e3d9c4
      
https://github.com/cytoscape/cytoscape.js/commit/75083ae462b808f52d15942a5e5240edf5e3d9c4
  Author: Max Franz <maxkfr...@gmail.com>
  Date:   2020-05-15 (Fri, 15 May 2020)

  Changed paths:
    M src/extensions/renderer/base/coord-ele-math/nodes.js

  Log Message:
  -----------
  Amend the parent node shape whitelist in the renderer

Refs.: Backport 3.14.x : The renderer overrides `round-rectangle` and 
`cut-rectangle` shapes on parents #2685 #2684


  Commit: 5e3d1c17bf6bec454ee95433592eac7e7538d2e7
      
https://github.com/cytoscape/cytoscape.js/commit/5e3d1c17bf6bec454ee95433592eac7e7538d2e7
  Author: Max Franz <maxkfr...@gmail.com>
  Date:   2020-05-15 (Fri, 15 May 2020)

  Changed paths:
    M src/style/properties.js

  Log Message:
  -----------
  Trigger a z-order event when an element's label changes from empty to 
non-empty or vice versa

If a node has `width: label` or `height: label`, a change of the label to or 
from the empty string makes the node have zero area.  This change makes it so 
that any change with an empty string causes a z-order event.  This event allows 
the renderer to recalculate the z-sorting of the elements, including which 
elements are interactive.  This sorting is used for hit tests.

This fix is simple, but it has the caveat that it triggers unnecessary z-sorts 
for elements that do not have `width: label` or `height: label`.  Given that a 
consumer is unlikely to be frequently setting labels to empty strings -- labels 
generally change infrequently, anyway -- the tradeoff is worth it.

Ref.: Backport 3.14.x : Changing a label of a node with width: label #2678 #2686


Compare: 
https://github.com/cytoscape/cytoscape.js/compare/422e732aff7e...5e3d1c17bf6b

-- 
You received this message because you are subscribed to the Google Groups 
"cytoscape-cvs" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to cytoscape-cvs+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/cytoscape-cvs/cytoscape/cytoscape.js/push/refs/heads/3.14.x/422e73-5e3d1c%40github.com.

Reply via email to