johnf schrieb: > Thanks I have not reviewed the patch. But have you tested your patch > against postgres 7.4 and against psycopg 1.x? For the moment we are > still providing ways to support both. I know that postgres 7.4 and > psycopg 1 are very old but it was a request from Ed. When we started > 7.4 was the dominant postgres version in use and psycopg 1 was the > only version. I know this sounds limiting. But if you can test would > you? I no longer have access to 7.4.
I haven't used any newer features than those already used in the trunk (note that the current trunk doesn't run out of the box with Pg 7.4 anyway, you at least have to manually add the "generate_series" function to make it work). I haven't used any newer psycopg features either. So nothing should be broken that wasn't broken before. But I noticed the current trunk already uses DictCursor which seems to be a psycopg2 feature and the docstring of the __init__ method also says only psycopg2 is supported. > That said, I believe we should drop support for postgres 7.4 and > psycopg 1. I strongly agree, since dabo 0.9 now officially requires Python 2.4 anyway (from the release dates, Py 2.3 goes along with Pg 7.4, while Py 2.4 goes with Pg 8.0; psycopg 2 beta was available shortly after Py 2.4, so this all makes sense). > And I think we should use all the features that Postgres offers and > psycopg 2 has to offer. Your example of using the `QuotedString()` is > only one of several that could be used. Btw, I noticed that some of the Python code is a bit old fashioned as well and can benefit a lot from using Py 2.4 features. > You may not be aware but some time in the future Dabo is scheduled to > move away from the present use of dbPostgres and other database > interfaces. And move to SQLAchemy or the some other tool to access > data. Just a FYI. That would be great. SQLAlchemy is great, I'm already using it elsewhere. I think it would be a perfect fit for dabo. The BizObjects could probably become SQLAlchemy ORM objects directly mapped to tables. But dabo will probably need more automated tests to make such large refactorings possible. > Please do not consider these statements in a negative way because I > do not want to discourage you in anyway. In fact it is nice to see > someone else that takes the time to help with the interface to > postgres. Just be aware. That's not discouraging at all :) -- Christoph _______________________________________________ Post Messages to: [email protected] Subscription Maintenance: http://leafe.com/mailman/listinfo/dabo-dev Searchable Archives: http://leafe.com/archives/search/dabo-dev This message: http://leafe.com/archives/byMID/[email protected]
