Abe Timmerman wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Steve Hay wrote:
> [snip]
>> Hmm. Nasty. I updated my Cygwin installation (used for the rsync of
>> the smoke source tree) on Friday afternoon, and it seems that the
>> three smokes over the weekend (Fri, Sat & Sun evening) have all
>> failed to rsync their source trees. They therefore ran with the
>> sources that were in place from the previous week since these smokes
>> (BCC/GCC/VC7) only run once a week. 
>> 
>> Not sure what to do about it, though. The new version of Cygwin /
>> rsync just doesn't seem to like the command that Test::Smoke uses,
>> despite it always having worked in the past:
> 
> *Really* nasty, so I fixed Test::Smoke.
> 
> It now chdir()s into the build dir and rsync()s to '.'
> 
> Please rsync latest Test::Smoke from
> rsync://source.test-smoke.org/ts-maint

Thanks for the quick fix!  I was on the brink of downgrading my rsync
from 2.6.9 back to 2.6.6, but now I won't bother.

I rsynced ts-maint (rev 1110) but I get a couple of test failures:

C:\Temp\Smoke>perl -Mblib t\syncer_rsync.t
1..33
ok 1 - use Test::Smoke::Syncer;
ok 2 - No error on no type
ok 3 - The object isa Test::Smoke::Syncer::Rsync
ok 4 - {ddir} exists
ok 5 - {ddir} value
ok 6 - {opts} exists
ok 7 - {opts} value
ok 8 - {rsync} exists
ok 9 - {rsync} value
ok 10 - {source} exists
ok 11 - {source} value
ok 12 - No error on type 'rsync'
ok 13 - The object isa Test::Smoke::Syncer::Rsync
ok 14 - {ddir} exists
not ok 15 - {ddir} value C:\usr\local\src\bleadperl\perl
#   Failed test '{ddir} value C:\usr\local\src\bleadperl\perl'
#   at t\syncer_rsync.t line 45.
#          got: 'C:\usr\local\src\bleadperl\perl'
#     expected: '\usr\local\src\bleadperl\perl'
ok 16 - {opts} exists
ok 17 - {opts} value -az --delete
ok 18 - {rsync} exists
ok 19 - {rsync} value rsync
ok 20 - {source} exists
ok 21 - {source} value ftp.linux.ActiveState.com::perl-current
ok 22 - No errror when options passed as hashref
ok 23 - The object isa Test::Smoke::Syncer::Rsync
ok 24 - {ddir} exists
not ok 25 - {ddir} value C:\usr\local\src\bleadperl\perl
#   Failed test '{ddir} value C:\usr\local\src\bleadperl\perl'
#   at t\syncer_rsync.t line 65.
#          got: 'C:\usr\local\src\bleadperl\perl'
#     expected: '\usr\local\src\bleadperl\perl'
ok 26 - {opts} exists
ok 27 - {opts} value -az --delete
ok 28 - {rsync} exists
ok 29 - {rsync} value rsync
ok 30 - {source} exists
ok 31 - {source} value ftp.linux.ActiveState.com::perl-current
ok 32 - Error on unknown type
ok 33 - Error message on unknown type
# Looks like you failed 2 tests of 33.

Reply via email to