On Fri, Sep 11, 2009 at 10:52:24AM +0100, Steve Hay wrote:
> Nicholas Clark wrote on 2009-09-11:
> > On Fri, Sep 11, 2009 at 10:30:10AM +0100, Steve Hay wrote:
> >> Nicholas Clark wrote on 2009-09-11:
> >
> >>> So does
> >>>
> >>> if (eval 'defined &DynaLoader::boot_DynaLoader') {
> >>>
> >>> fix it?
> >>
> >> Yes, that fixes it.
> >
> > Do you want to commit it, or do I?
>
> I was assuming you would, since it's your fix ;-)
I was assuming that it's not as good if I do it, because I can't run make
test before pushing to the world.
> But I'll do it if you're not hooked up at the moment.
If you could, that would be great.
> > We've already got changes, so I'm going to need to send a patch to
> > MakeMaker RT queue anyway.
> >
> > (Which I'm hoping will make Schwern mostly smile, as it's nearly all
> > removing $ENV{PERL_CORE} boilerplate)
And I was not thinking straight, as this is a change to Cwd, not MakeMaker.
But on reflection, I still think that it's the right change. Or at least,
the least worst change.
> Yes, I was also half-thinking that we shouldn't be applying things
> directly here anyway (but there may be an exception to the rule for
> fixing smoke failures?)
Yes, I believe that that was roughly the rule we were working on.
Smoke failures are worse than blead being identical to CPAN, because smoke
failures really get in the way of anything else.
Nicholas Clark
