A few nits:
1) I would recommend that PS (perl-smoke directory) be defined in
smoke.sh and then referenced in the line that calls mktest.pl. I had
originally set mine up so that it would just assume that perl-smoke is
in the parent directory, but now that I'm running out of a checked-out
CVS directory, this isn't as workable.
RCS file: /cvsroot/perl-qa/smoke/smoke.sh,v
retrieving revision 1.1
diff -r1.1 smoke.sh
4a5,6
> # Change your smoke dir here
> PS=//d/research/perl-qa/smoke
6c8,9
< export PC=/usr/3gl/CPAN/perl-current
---
> PC=//d/research/perl-current/
> export PC PS
16c19
< (mktest.pl 2>&1) >mktest.log
---
> ($PS/mktest.pl 2>&1) >$PS/mktest.log
RCS file: /cvsroot/perl-qa/smoke/README,v
retrieving revision 1.1
diff -r1.1 README
10,11c10,12
< Then edit smoke.sh (line 6) and mkovz.pl (line 5) to reflect
< the location (directory) of your smoking pit
---
> Then edit smoke.sh (line 8) and mkovz.pl (line 5) to reflect
> the location (directory) of your smoking pit. Also update
> smoke.sh (line 6) to point at the directory with the smoke tools.
2)
$ perl -c mktest.pl
Array found where operator expected at mktest.pl line 151, near "m,^All
tests su
ccessful, "
syntax error at mktest.pl line 151, near "m,^All tests successful, @nok"
syntax error at mktest.pl line 162, near "else"
Global symbol "@nok" requires explicit package name at mktest.pl line
165.
Global symbol "@nok" requires explicit package name at mktest.pl line
169.
Global symbol "@nok" requires explicit package name at mktest.pl line
175.
syntax error at mktest.pl line 182, near "}"
mktest.pl had compilation errors.
This seems to fix it:
RCS file: /cvsroot/perl-qa/smoke/mktest.pl,v
retrieving revision 1.1
diff -r1.1 mktest.pl
151c151
< if (grep m,^All tests successful, @nok) {
---
> if (grep {/^All tests successful/} @nok) {
Index: smoke.sh
3) I typically change the invocation of mktest.pl to run via tee instead
of just dumping to a log file, but I don't usually run this via cron. If
it's worth making this config'able, let me know, I'll add a --verbose
option or something. (should we just make smoke.sh be a perl script? =-)
I'll let y'all know if I can get win98/cygwin smoking.
Ask Bjoern Hansen wrote:
>
> [EMAIL PROTECTED] (Will Coleda) writes:
>
> > Are any files actually available from sourceforge yet? I see no
> > released files, and I can't get at the FTP drop. (though I am behind
> > a f/w, using a machine I can't easily config things on...)
>
> Try via anonymous cvs.
>
> :)
>
> - ask
>
> --
> ask bjoern hansen, http://ask.netcetera.dk/ !try; do();
