On Tuesday 02 August 2005 13:34, David Roundy wrote:
> On Mon, Aug 01, 2005 at 08:39:45PM -0400, Matt Lavin wrote:
> > Here's a pretty simple test and fix for bug 463. I also noticed
> > that bug 194 seems to be fixed but the ticket is still open.
> >
> > Mon Aug 1 20:21:16 EDT 2005 Matt Lavin <[EMAIL PROTECTED]>
> > * fix for bug 463 (with new test)
>
> Thanks for the bugfix! (and I've now also resolved 194.)
>
> > hunk ./Add.lhs 256
> > - return $ f: map (\f'->f++"/"++f') fs
> > + return $ f: map (\f'-> join f f') fs
> > + where join base ('.':'/':rest) = join base rest
> > + join base dir = base ++ "/" ++ dir
>
> Note that this is a nice opportunity for the inline syntax:
>
> return $ f: map (`join` f') fs
Isn't f' undefined in that case? Shouldn't that be
return $ f: map (join f) fs
instead? That would be a partial function application (aka cut), not an
inline operator. You may be thinking of
\f' -> join f' f
which is
\f' -> f' `join` f
which is
(`join` f)
But I haven't looked at the surrounding code, so I may be way off here.
-erik
--
Erik Schnetter <[EMAIL PROTECTED]> http://www.aei.mpg.de/~eschnett/
My email is as private as my paper mail. I therefore support encrypting
and signing email messages. Get my PGP key from www.keyserver.net.
pgpXZhA4OQrU8.pgp
Description: PGP signature
_______________________________________________ darcs-devel mailing list [email protected] http://www.abridgegame.org/cgi-bin/mailman/listinfo/darcs-devel
