On 12/12/05, Will <[EMAIL PROTECTED]> wrote: > Sun Dec 11 20:44:47 MST 2005 Will <[EMAIL PROTECTED]> > * fix bad grep option in send test case > > Sun Dec 11 20:51:03 MST 2005 Will <[EMAIL PROTECTED]> > * fix bug in exec of sendmail command
I have sent patch to fix this as well [1]. It fixes exactly the same typo as you did, but has different changes to tests (imo more correct). The fix (on yours and on my patch) potentially breaks use-case of cat (or similar) as --sendmail-command. This breakage only happens on non-Windows platforms. I believe that the testcases, and use-case, will fail on non-Windows platforms after your patch because they rely on being able to pipe mail forward from --sendmail-command, it doesn't work anymore because stdout is now bound to /dev/null, and not invalid handle or original stdout (I don't know exactly what happened when opening/dupping to non-existing, non-creatable file /dev/nulll). Windows exec is diffrent than one used in unixy platforms, and it doesn't redirect io to /dev/null (or null, that'd work in Windows command prompt) and hence cat etc can be used conviently from --sendmail-command. I have no idea about grep -x vs grep; grep -x works in my msys perfectly well. [1] http://www.abridgegame.org/pipermail/darcs-devel/2005-November/003583.html Best regards, --Esa _______________________________________________ darcs-devel mailing list [email protected] http://www.abridgegame.org/cgi-bin/mailman/listinfo/darcs-devel
