Tommy Pettersson wrote:
I've reviewed and tested these patches on linux with ghc 6.4.


| Wed Nov 29 17:01:44 CET 2006  Simon Marlow <[EMAIL PROTECTED]>
|   * add explicit import list

| Wed Nov 29 17:03:42 CET 2006  Simon Marlow <[EMAIL PROTECTED]>
|   * hFlush after "waiting for lock" message

| Wed Nov 29 17:06:20 CET 2006  Simon Marlow <[EMAIL PROTECTED]>
|   * catch exceptions in stdout_is_a_pipe

These three looks good and works fine.



| Wed Nov 29 17:07:10 CET 2006  Simon Marlow <[EMAIL PROTECTED]>
|   * Use System.Process on Windows

This one I couldn't compile, but the following changes fixed it:

  hunk ./Exec.lhs 25
  -import System.Exit      ( ExitCode )
  +import System.Exit      ( ExitCode(..) )
  hunk ./Exec.lhs 39
  -import System
  +import System.IO ( stdin )
  +import Control.Exception ( bracket )

I can not test this patch since it's windows only, but I tried
to compile with #define WIN32, and got:

  Exec.lhs:33:27: Module `Control.Exception' does not export `bracketOnError'

Don't know if that's important, but I thought I'd mention it.

Thanks for taking a look.

These are due to changes in libraries between versions of GHC; bracketOnError only appeared in GHC 6.6, it seems. So we need some configure tests to straighten things out. Can I leave these up to you guys to sort out?

Cheers,
        Simon


_______________________________________________
darcs-devel mailing list
darcs-devel@darcs.net
http://www.abridgegame.org/cgi-bin/mailman/listinfo/darcs-devel

Reply via email to