On Sat, May 05, 2007 at 03:12:41AM -0700, Jason Dagit wrote: > This adds the sometimes requested feature of prehooks. It does the simplest > thing possible. That is, I copied the code for posthooks and changed post to > pre and also made sure it runs before darcs runs.
Looks good to me. I've read over the code, and the only thing that I'd prefer to do differently would be to make prehooks run by default (as with posthooks), but I'll respect Jason's preference to prompt by default. I would prefer *not* to propogate the hooks with darcs get. If we did that, then I'd agree with Jason's preference to not run them by default, but at that point the convenience of propogating hooks would largely be negated, since the users would still need to edit their defaults file in order to actually use the hooks without being prompted on each darcs command. We could add a feature to darcs get such as --copy-defaults which grabs the whole defaults file (possibly filtering out some defaults such as --author-name?), but if we did this, I'd rather not make the code hook-specific. Speaking of which, Jason, if you could add send --unified to your defaults file, that would be great! An example of why --copy-defaults would be helpful for other features than hooks... -- David Roundy http://www.darcs.net _______________________________________________ darcs-devel mailing list darcs-devel@darcs.net http://lists.osuosl.org/mailman/listinfo/darcs-devel
