On 7/27/07, Eric Y. Kow <[EMAIL PROTECTED]> wrote: > > Sun Jul 22 23:56:21 MST 2007 Kevin Quick <[EMAIL PROTECTED]> > > * Always use cloneFile for copying files. > > Seems like a good refactor. Going in, thanks. > > > Mon Jul 23 00:15:33 MST 2007 Kevin Quick <[EMAIL PROTECTED]> > > * Use System.Directory.copyFile for file copying. > > David: Do you have any comments on this? > > On the one hand, it is good in general to use standard lib functions. > On the other hand, maybe our cloneFile is written deliberately in a > special way (for example, it does not copy permissions -- feature?).
I think it would be nice to see a benchmark between the old and new where there are thousands of tiny little files. Is there a noticeable performance difference? The reason for lots of little files is because of the permission copying. I don't know that it would affect the performance, but if the permission changes require a lot of function calls then it could have a big impact. Jason _______________________________________________ darcs-devel mailing list darcs-devel@darcs.net http://lists.osuosl.org/mailman/listinfo/darcs-devel
