On Wed, Jan 23, 2008 at 01:04:39AM +0100, Tommy Pettersson wrote: > On Tue, Jan 22, 2008 at 05:52:28PM -0500, David Roundy wrote: > > On Tue, Jan 22, 2008 at 11:37:33PM +0100, [EMAIL PROTECTED] wrote: > > > Tue Jan 22 14:43:22 CET 2008 Tommy Pettersson <[EMAIL PROTECTED]> > > > * use UTC in date matching test untill match handles time zones > > > > I'm not entirely comfortable with this, as it hides the fact that we've got > > a real bug remaining. I guess so long as we don't close it on the bug > > tracker, we'll not forget it... (and it's hardly fair that the test suite > > usually passes for me, just because I'm not too far from England and prefer > > not to work on the computer at night). > > It's also a bit uncomfortable when a test fails some times but > not other times. For me the test fails between midnight and > 01:00, which happens at times. :-)
I agree that that is a pain. On the other hand, once the code is fixed, I think this will be an advantage, having the test suite run a subtly different test every time it's run. The result will be that when averaged over all the folks who run make check--provided folks notify us when it goes bad--we'll have verification that the test works at all times of day in all time zones. Admittedly, it may be somewhat sparse sampling, but over time this ought to ensure that darcs' date matching is robust. And once darcs' date matching *is* robust, then the test should pass for all time zones (as long as we avoid actually trying to parse the three-letter timezone abbreviation in the test). -- David Roundy Department of Physics Oregon State University _______________________________________________ darcs-devel mailing list darcs-devel@darcs.net http://lists.osuosl.org/mailman/listinfo/darcs-devel
