On Sun, Nov 12, 2006 at 07:11:21PM +0200, Yuval Kogman wrote: > On Sun, Nov 12, 2006 at 15:47:00 +0000, Jamie Webb wrote: > > > I suspect your hand-typed version is not quite correct: I think both > > subs start with the line 'my $self = shift'. When Darcs encounters > > that line in the new function, it matches it up with the existing > > identical line. > > Both are "correct" in that sense (i did have a small erro, as David > noted).
I was ignoring that error. I think you left out a whole line in your hand-written one. Specifically, where does $self come from? I'm guessing it's not a global... Thus, I think Darcs did find an optimal diff, it just wasn't the one you wanted. > However, the OP mentioned that sometimes the algorithm > behaves in a way which is suboptimal, even if correct. Maybe. I just suspect the OP likewise confused an unintuitive diff with a suboptimal one. That doesn't mean there's not room for improvement, but it's important to be sure what the actual problem is. (Does svn really do better, or do people just not notice, because they have to deal with diffs less?) -- Jamie Webb _______________________________________________ darcs-users mailing list [email protected] http://www.abridgegame.org/mailman/listinfo/darcs-users
