Hi Jason, I've applied the first two of these, but not the rest, since I ran out of time for reviewing. I'll take a look at the rest later. The first two look good. One thing I noticed in Choices was that it would be nice to remove the separate_first_middle_from_last and friends, now that we've got your improved get_choices. The "separate" functions were written to provide a "safer" interface for get_first_changes and friends, but at this point I think it'll be clearest to just use get_choices, which makes the "first", "middle" and "last" explicit in the type. (But this needn't be something that is fixed soon...)
David On Tue, Aug 12, 2008 at 10:37 PM, Jason Dagit <[EMAIL PROTECTED]> wrote: > David, > > This is a big patch bundle, but most of the important changes are in > SelectChanges. I found that module particularly tricky. I think > the current types are right and I believe I didn't break anything > during the refactor. And in fact, at least twice I tried to introduce > bugs but the enhanced type safety caught it. > > Thanks, > Jason > > Fri Aug 8 17:02:37 PDT 2008 Jason Dagit <[EMAIL PROTECTED]> > * add type witnesses to Patch/Choices.lhs > > Sat Aug 9 23:34:03 PDT 2008 Jason Dagit <[EMAIL PROTECTED]> > * add type witnesses to TouchesFiles > > Tue Aug 12 20:16:25 PDT 2008 Jason Dagit <[EMAIL PROTECTED]> > * major refactor of SelectChanges to work with type witnesses > > Tue Aug 12 21:43:54 PDT 2008 Jason Dagit <[EMAIL PROTECTED]> > * make WhatsNew work with type witnesses > > Tue Aug 12 22:04:25 PDT 2008 Jason Dagit <[EMAIL PROTECTED]> > * refine type witnesses in SelectChanges > > _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
