On Mon, Oct 13, 2008 at 12:08:48AM +0100, Eric Kow wrote: > Sun Oct 12 14:30:17 CEST 2008 Matthias Kilian <[EMAIL PROTECTED]> > * Remove bashisms and GNUisms > > Replace some bashisms and GNUisms by more standards compliant command > lines, i.e.: > > - Don't use `\|' in BREs, since it's undefined according to POSIX. > Instead just use grep -E with an ERE. > > - Don't create "funny" strings with the $'\x01...' bashism but use > printf(1) instead. Note that this isn't strictly necessary to fix > printer.sh on non-GNUish systems, but it makes it much simpler to test > what's going on. > > - In test_line(), just use grep -F, and unescape all second arguments > passed to test_line(). This makes the script much more readable and > actually fixes it for non-GNUish systems.
Applied, thanks! And please, do keep in mind, everyone, that there's no need to eliminate bashisms, as our tests are run with bash. Removing gnuisms from the use of grep and sed, on the other hand, is definitely a good idea. David
signature.asc
Description: Digital signature
_______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
