On Sun, Nov 02, 2008 at 10:58:16PM +0000, Ganesh Sittampalam wrote: > On Sun, 2 Nov 2008, David Roundy wrote: > > >On Sun, Nov 02, 2008 at 10:39:07PM +0000, Ganesh Sittampalam wrote: > > >>So I do think this should go in. > > > >Ah, okay, that's good to hear. It did seem like they should be an > >improvement... do you have any suggestions for a possible subportion that > >would be worth reviewing separately, as this looks a bit daunting to finish > >this evening? > > I've added in "-----" to my earlier commentary to delimit bits that can > sanely be reviewed independently (and in one case reordered slightly), but > there's no point in actually applying until you get down to the point > where I say "reasonable to actually apply", because there's no actual > benefit from the changes until that point:
Looks good, and it's going in. Those little "------"s lured me along from one patch to another, knowing I could stop any time... :) (Also, your changes were pretty well split up, so the only large ones were pretty simple refactors.) David > Patch-by-patch commentary: > > ----- > > This patch should leave behaviour unchanged, but exposes the > fact that both SlurpFile and SlurpDir specify a filename by > lifting it into a common place: > > Sun Oct 26 12:37:22 GMT 2008 Ganesh Sittampalam <[EMAIL PROTECTED]> > * refactor Slurpy to common up name component between File/Dir > > ----- > > This switches SlurpDir over to using a Data.Map. This means that > files will always be in lexicographic order in each directory. > It does things in a dumb way, just switching back to [Slurpy] in > any place that actually wants one. > > Sun Oct 26 13:59:06 GMT 2008 Ganesh Sittampalam <[EMAIL PROTECTED]> > * dumb changeover of SlurpDir contents from [] to Map > > ----- > > Some simple changes to actually make use of the fact that > we now have a Map: > > Sun Oct 26 15:37:49 GMT 2008 Ganesh Sittampalam <[EMAIL PROTECTED]> > * make use of the SlurpyDir Map in the obvious places > > Sun Oct 26 18:55:18 GMT 2008 Ganesh Sittampalam <[EMAIL PROTECTED]> > * bug fix > > ----- reasonable to actually apply the groups once you get to this point > (and any thereafter) > > Sun Oct 26 19:27:15 GMT 2008 Ganesh Sittampalam <[EMAIL PROTECTED]> > * another obvious use of the SlurpyMap > > ----- > Sun Oct 26 20:04:42 GMT 2008 Ganesh Sittampalam <[EMAIL PROTECTED]> > * simplify slurp_has_anycase > > ----- > > And some other cleanups to SlurpDirectory: > > Minor: > > Tue Oct 28 06:54:24 GMT 2008 Ganesh Sittampalam <[EMAIL PROTECTED]> > * cleanup some patterns > > ----- > > Repository.HashedIO was the only module that used access to the > internals of a Slurpy. This patch makes that explicit: > > Tue Oct 28 07:29:11 GMT 2008 Ganesh Sittampalam <[EMAIL PROTECTED]> > * clarify SlurpDirectory interface > > This one goes together with "clarify SlurpDirectory interface" > > Wed Oct 29 19:07:15 GMT 2008 Ganesh Sittampalam <[EMAIL PROTECTED]> > * fixup SRC_DIRS > > ----- > > Minor: > > Tue Oct 28 18:53:58 GMT 2008 Ganesh Sittampalam <[EMAIL PROTECTED]> > * a slight simplification > > > ----- -- David Roundy http://www.darcs.net _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
