I intend to apply these, thanks! Do you have any particular refactors or tidy-ups in mind for the future? Just curious :-)
+tests/lib.sh: library for test scripts tests/*.sh: factor out definitions of portable_pwd to lib.sh tests/*.sh: factour out ~61 of the 'not' definitions to lib.sh tests/*.sh: factor out windows abortion --------------------------------------- I trust that these are unchanged since Trent's review Add --disable-unit to configure script Remove mention of unstable branch from the homepage --------------------------------------------------- Patches from the now defunct unstable mv lib.sh -> lib & update callers --------------------------------- Whole bunch of replace patches tests/lib: rm shebang header ---------------------------- As requested by Trent tests/*.sh: remove "set -ev" from all callers of lib ---------------------------------------------------- > alias pwd=hspwd On a random note, I thought I should point out that portable_pwd can now be replaced by something like this. Presumably putting this alias into the lib should help. Also, I think this means we get to get rid of the silly IFS hacks tests/README.test_maintainers.txt: add a section on the use of lib ------------------------------------------------------------------ > - -Output like "good" and "OK, passed 100 tests." is good. Output like > - -"*** Gave up! Passed only n tests." is a shortage of quickcheck test > +Output like "good" and "OK, passed 100 tests." is good. Output like > +"*** Gave up! Passed only n tests." is a shortage of QuickCheck test I definitely appreciate the README cleanup! For future reference, we generally like to keep orthogonal changes in orthogonal patches, as requested in http://wiki.darcs.net/index.html/DeveloperGettingStarted -- Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> PGP Key ID: 08AC04F9
pgpjxOaBt0nTy.pgp
Description: PGP signature
_______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
